Changed deprecated keys and used cryptosigner #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dariksha <[email protected]>
|
@lukpueh I have changed all the files you've mentioned , PTAL !! |
lukpueh
requested changes
May 17, 2024
There was a problem hiding this comment.
Thanks!! This is almost complete. Can you please check the ci log and fix the errors? You can also run the test locally:
python3 run_demo_md.pyI few hints:
- The functionary keys in
create_layout.py(key_bob and key_carl) are no longer key dictionaries butKeyobjects now. You need to slightly adopt the way they are used in the rest of the script. - If you do change the commands in
README.md, you'll also need to update the expected output inrun_demo_md.py. But you can also leave that for a separate PR, as we discussed.
Signed-off-by: Dariksha <[email protected]>
lukpueh
reviewed
May 17, 2024
owner_alice/create_layout.py
Outdated
| key_dict = key.to_dict() | ||
| key_dict["keyid"] = key.keyid | ||
|
|
||
| return key_dict |
There was a problem hiding this comment.
(edit: fix function name)
IMO it's okay to just import this internal method from in_toto:
# https://github.com/in-toto/in-toto/issues/663
from in_toto.models._signer import load_public_key_from_file
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
|
Hm. Tests are still failing. Feel free to debug, but this might be a bit tricky. I am happy to take over. |
Signed-off-by: Dariksha <[email protected]>
Signed-off-by: Dariksha <[email protected]>
lukpueh
approved these changes
May 21, 2024
|
Thank you @lukpueh working with this issue is so interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixed issues #73 , #74 , #68 "
changed in readme.md and run_demo.py
in-toto-run with --key is now --signing-key
in-toto-record with --key is now --signing-key
in-toto-verify with --layout-keys is now --verification-keys
Used CryptoSigner instead of signer in create_layout.py and added module requirement in requirements.txt